refactor(spacing): generate spacing atomic classes programatically#1654
refactor(spacing): generate spacing atomic classes programatically#1654dancormier merged 10 commits intodevelopfrom
Conversation
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This refactor makes a lot of sense to me. I just glanced at the PR and left a comment. I will do a full review once you mark the PR as ready for review. Thanks @dancormier |
There was a problem hiding this comment.
@dancormier Not perfect but at least we have a diff of what changed now. Let me know when this PR is ready for a final review.
There was a problem hiding this comment.
It's ready for your review now but no rush on this one
…s created by mistake
giamir
left a comment
giamir
left a comment
There was a problem hiding this comment.
I took the liberty to push this commit and made a small observation about the docs missing myn.
Thanks for doing this refactor. I am good to merge when you are. 🙏
2 participants
This PR expands on #1652 and closes #1653
Spacing class generation is prone to bugs and accidental omissions. This PR make generation of spacing (and incidentally, positioning) atomic classes and documentation more programmatic.