Refactor loader to loading, match styles to spec #2150
+178
−186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| --_ld-block-size: calc(var(--su-static8) - var(--su-static1)); | ||
| --_ld-gap: calc(var(--su-static2) + var(--su-static1)); | ||
| --_ld-start-offset: var(--su-static2); | ||
| .s-loader { |
Collaborator
There was a problem hiding this comment.
I spoke to Caro because the Figma called it Loader but the story said Loading, she confirmed it is Loader. I forgot to update the ticket sorry! I've changed it back to loader
| {@render children()} | ||
| {:else} | ||
| >{#if loading}<Loader | ||
| size="sm" |
Collaborator
There was a problem hiding this comment.
how would the user update the label for internationalization? should we add another prop if we're not gonna use a Snippet?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ttaylor-stack this PR refactors your PR to match the specifications in SPARK-117. Most notably:
Loadinginstead ofLoader.s-loader--block. The--*suffixes are reserved for component child elements.CurrentColoris used for background color so it matches contextWhat's still needed to complete ticket