Tweak label and related spacing #2165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lifts spacing out of the
.s-labelcomponent and into the parent.s-form-groupcomponent. This will require the.s-form-groupclass to be present on any form groups. Most of the changes are on docs pages to add this class and remove other atomic classes that are now handled by the respective component styles.This PR only alters Stacks Classic and Stacks Docs. Changes to class structure will be necessary on Svelte components.
Note
I haven't 100% verified the spacing all around but I think it matches the Figma. If it doesn't, it should be pretty trivial to update.