core: Add TLSA record support#203
Merged
tlimoncelli merged 14 commits intoStackExchange:masterfrom Sep 15, 2017
Merged
Conversation
added 14 commits
September 12, 2017 04:34
Altered validate.go:checkLabel to skip warnings for types that allow leading underscores: SRV, TXT, TLSA Altered validate_test.go to test for new check types and also changed existing tests to include expected failing tests
Contributor
Author
|
Significant changes to existing validation and tests in c224e28 I added tests for SRV, TLSA and TXT that include underscores in labels. In checkLabel, I added a pass filter for those record types. The corresponding tests were updated to check the new types. Existing checks were updated to accommodate the new required arguments. |
Contributor
|
Fantastic! Thanks for the big PR! |
captncraig
changed the title
rblenkinsopp
pushed a commit
to rblenkinsopp/dnscontrol
that referenced
this pull request
Aug 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for TLSA records.
Sample record:
TLSA("_443._tcp", 3, 1, 1, "959fff14d3...82ffa1517e2c", TTL(300))