Vultr: New Provider!#219
Vultr: New Provider!#219tlimoncelli merged 7 commits intoStackExchange:masterfrom pgaskin:add-vultr-provider
Conversation
|
cc @captncraig |
|
I am finished this PR. |
|
Wow! this looks great. I'll take a good look over it tomorrow. |
|
@captncraig Thanks! Btw, I have written code in go before 😃. Also, I will submit some more PRs for improving the docs, and some of the other providers. |
|
Sure, some of these bits have grown organically, so I'd love any feedback you have to offer. Some of the pain points I know about, but its always good to have a new set of eyes for honest feedback. |
|
@captncraig ok. |
|
Review please |
| } | ||
|
|
||
| var vd *vultr.DNSDomain | ||
| for _, d := range domains { |
There was a problem hiding this comment.
does their api do any kind of paging we need to worry about?
There was a problem hiding this comment.
Nope. Passes integration tests and I tried myself with 300 entries.
providers/vultr/vultr.go
Outdated
| rc.Target = dnsutil.AddOrigin(target, dc.Name) | ||
| } | ||
|
|
||
| // #rtype_variations |
There was a problem hiding this comment.
I don't think we need this #comment everywhere here. Just at the top so this function shows up in grep.
There was a problem hiding this comment.
Ok, the docs on adding rtypes were not all that clear, I guess I will fix that next.
| } | ||
|
|
||
| // #rtype_variations | ||
| if r.Type == "SRV" { |
There was a problem hiding this comment.
I believe there are some helper functions in the models package for splitting out srv/caa records from a single field representation. Is vultr doing something odd so that those don't work?
There was a problem hiding this comment.
I'll have to look into that, but Vultr does quite a few funny things, so it may be better to manually handle it.
There was a problem hiding this comment.
The helper functions do not use the right order for Vultr.
…control/adding-new-rtypes
|
@captncraig Ready for another review. |
|
Looks great! Thanks! |
|
@tlimoncelli No problem! |
* Added Vultr provider * Fixed tests * Fixed CI build validation * Add unsupported features * Added #rtype_variations tags according to stackexchange.github.io/dnscontrol/adding-new-rtypes * Add title (for compatibility with StackExchange#223) * Removed extra rtype_variations
* Added Vultr provider * Fixed tests * Fixed CI build validation * Add unsupported features * Added #rtype_variations tags according to stackexchange.github.io/dnscontrol/adding-new-rtypes * Add title (for compatibility with StackExchange#223) * Removed extra rtype_variations
4 participants
I have added the Vultr provider. This PR includes full support for all supported features from Vultr (SRV, CAA, CreateDomains).
I have tested this with both the integration tests, and my own domain.
See issue #217