Improved BIND docs (#221)#226
Merged
tlimoncelli merged 2 commits intoStackExchange:masterfrom Oct 11, 2017
pgaskin:website-fixes-bind
Merged
Improved BIND docs (#221)#226tlimoncelli merged 2 commits intoStackExchange:masterfrom pgaskin:website-fixes-bind
tlimoncelli merged 2 commits intoStackExchange:masterfrom
pgaskin:website-fixes-bind
Conversation
- Fixed highlighting language - Improved markdown formatting - Improved grammar
tlimoncelli
reviewed
Oct 11, 2017
docs/_providers/bind.md
Outdated
|
|
||
| This provider simply maintains a directory with a collection of .zone files. We currently copy zone files to our production servers and restart bind via | ||
| a script external to DNSControl. | ||
| This provider maintains a directory with a collection of .zone files. We currently copy zone files to our production servers and restart bind via a script external to DNSControl. |
Contributor
There was a problem hiding this comment.
Please change "We currently..." to "Pushing the zone files is left to you as different sites do this differently. Commonly people run a bash script that copes the files to the master and runs the proper command to notify the server."
Collaborator
Author
There was a problem hiding this comment.
I'll fix this and finish with the rest in a few hours.
koesie10
pushed a commit
to koesie10/dnscontrol
that referenced
this pull request
Nov 14, 2017
* Improved BIND docs - Fixed highlighting language - Improved markdown formatting - Improved grammar * Fix according to review
rblenkinsopp
pushed a commit
to rblenkinsopp/dnscontrol
that referenced
this pull request
Aug 21, 2020
* Improved BIND docs - Fixed highlighting language - Improved markdown formatting - Improved grammar * Fix according to review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #221