Source filenames should be consistent.#261
Merged
tlimoncelli merged 1 commit intomasterfrom Nov 7, 2017
Merged
Conversation
Contributor
tlimoncelli
commented
Nov 1, 2017
tlimoncelli
commented
- Fixes Source filenames should be consistent #251
Collaborator
|
I think it should not be main.go for every provider, because the filename should be the package name (this is how many go projects work). |
tlimoncelli
force-pushed
the
tlim_rename
branch
from
b695733 to
34b7baa
Compare
Contributor
Author
|
@geek1011 makes a good point. I've corrected the few that were not in the current pattern (name/nameProvider.go). At least that fixes the immediate issue. |
tlimoncelli
pushed a commit
that referenced
this pull request
Nov 7, 2017
pmoroney
pushed a commit
to pmoroney/dnscontrol
that referenced
this pull request
Jan 11, 2018
rblenkinsopp
pushed a commit
to rblenkinsopp/dnscontrol
that referenced
this pull request
Aug 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.