Skip to content

Simple notification framework#297

Merged
captncraig merged 5 commits intomasterfrom
notify
Jan 11, 2018
Merged

Simple notification framework#297
captncraig merged 5 commits intomasterfrom
notify

Conversation

@captncraig
Copy link
Copy Markdown
Contributor

This adds a notifications package to dnscontrol!

A notifier is a function that accepts domain, provider, message, error, and preview flag, and sends data to anywhere it likes. This will always be run after a correction is complete.

Can be run on preview or push by using -notify flag. Configuration is intended to be passed in creds.json under notifications key:

"r53": {
      ...
    },
    "gcloud": {
        ...
  } ,
  "notifications":{
      "bonfire_url": "https://chat.meta.stackexchange.com/feeds/rooms/123?key=xyz"
  }

Currently only implemented bonfire notification for stack internal chat. Easy additions in the future:

  • Slack
  • Email
  • Generic http
  • Simple body templating for some or all of above.

@captncraig captncraig requested a review from tlimoncelli January 9, 2018 15:40
@tlimoncelli
Copy link
Copy Markdown
Contributor

Wow! That's pretty cool!

Could you add some documentation and then merge it?

Tom
P.S. I think you mean s/nofitier/notifier/g

@captncraig captncraig merged commit 9dbd4a3 into master Jan 11, 2018
@tlimoncelli tlimoncelli deleted the notify branch January 25, 2018 17:55
rblenkinsopp pushed a commit to rblenkinsopp/dnscontrol that referenced this pull request Aug 21, 2020
* bonfire notifications working

* make interface to make more extensible

* some docs

* typo

* rename typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants