add TXTMulti capability to the namedotcom provider#299
Merged
tlimoncelli merged 3 commits intoStackExchange:masterfrom Jan 11, 2018
Merged
add TXTMulti capability to the namedotcom provider#299tlimoncelli merged 3 commits intoStackExchange:masterfrom
tlimoncelli merged 3 commits intoStackExchange:masterfrom
Conversation
Contributor
Author
|
Just realized I forgot to escape any quotes in the multitxt when sent to the API. I'll add that and an integration test when I get back to a computer. |
rblenkinsopp
pushed a commit
to rblenkinsopp/dnscontrol
that referenced
this pull request
Aug 21, 2020
* add TXTMulti capability to the namedotcom provider * run go generate * escape multi txt records before sending to the API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe we support the TXTMulti capability, these changes should allow it.
Let me know if the resulting DNS entries don't look right in production.