Update helpers.js CAA_CRITICAL flag=128 (#318)#319
Update helpers.js CAA_CRITICAL flag=128 (#318)#319tlimoncelli merged 3 commits intoStackExchange:masterfrom ismaelperal:master
Conversation
CAA flag "Issuer Critical Flag" sets first bit (bit 0) to 1 where bit 0 is the 8th bit in the flag, so it's doing the change by left shift 7 positions the value 1.
|
It seems there is a test failing. The value in https://github.com/StackExchange/dnscontrol/blob/master/pkg/js/parse_tests/014-caa.json needs to be updated. |
Apply changes for Travis-CI, now caaflag must be 128 instead of 1.
|
@captncraig thanks, I wasn't aware of this tests. I've updated it. Now I don't know the reason why it's failing: after -> go run build/validate/validate.go Did I miss something else? Thank you! |
|
That just means you need to run "go generate". Any changes to helpers.js require a run of "go generate" to embed helpers.js in the binary. |
|
By the way... I don't use CAA (yet) so when I created the integration tests, I was just guessing about what would be important. If you could look at https://github.com/StackExchange/dnscontrol/blob/master/integrationTest/integration_test.go#L410 and suggest improvements, please let fee free to add/change them. |
|
@tlimoncelli Thanks, I will! I think something is wrong in my development environment, sorry for the inconvenience and thanks for your help |
|
I think you'll be fine if you rebase then to "go generate". Let me know if you need assistance. |
…StackExchange#319) * Update helpers.js CAA_CRITICAL flag=128 (StackExchange#318) CAA flag "Issuer Critical Flag" sets first bit (bit 0) to 1 where bit 0 is the 8th bit in the flag, so it's doing the change by left shift 7 positions the value 1. * Change caa tests Apply changes for Travis-CI, now caaflag must be 128 instead of 1. * generated static.go and matrix.html
3 participants
CAA flag "Issuer Critical Flag" sets first bit (bit 0) to 1 where bit 0 is the 8th bit in the flag, so it's doing the change by left shift 7 positions the value 1.
#318 - RFC 6844