Refactor in preparation to unexport RecordConfig.{Name,NameFQDN,Target}#337
Merged
tlimoncelli merged 12 commits intomasterfrom Mar 19, 2018
Merged
Refactor in preparation to unexport RecordConfig.{Name,NameFQDN,Target}#337tlimoncelli merged 12 commits intomasterfrom
tlimoncelli merged 12 commits intomasterfrom
Conversation
Contributor
|
The one thing that makes unexporting those really tricky is that the json deserializes into those. I have a few convoluted solutions to that problem, but none I really love. |
Contributor
Author
|
I'm no where near ready to unexport them (the branch name is a bit misleading). I just want to be prepared for when we do. I believe this is the most we can do without actually un-exporting those fields. |
rblenkinsopp
pushed a commit
to rblenkinsopp/dnscontrol
that referenced
this pull request
Aug 21, 2020
…t} (StackExchange#337) * Preparing for the unexport of Name/NameFQDN/Target * Cleanups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.