Fix #339 prevent the ovh provider to panic on SPF and DKIM record types#340
Merged
tlimoncelli merged 1 commit intoStackExchange:masterfrom Mar 21, 2018
Conversation
OVH uses special SPF and DKIM invalid types for records added with the web ui (or default zone records). The ovh provider didn't correctly handle those invalid record types and was panic'ing. This change prevents the panic by converting such records to TXT (which is what they are in fact), but also auto-corrects any SPF or DKIM records to TXT ones.
rblenkinsopp
pushed a commit
to rblenkinsopp/dnscontrol
that referenced
this pull request
Aug 21, 2020
OVH uses special SPF and DKIM invalid types for records added with the web ui (or default zone records). The ovh provider didn't correctly handle those invalid record types and was panic'ing. This change prevents the panic by converting such records to TXT (which is what they are in fact), but also auto-corrects any SPF or DKIM records to TXT ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OVH uses special SPF and DKIM invalid types for records added with the web ui (or default zone records).
The ovh provider didn't correctly handle those invalid record types and was panic'ing.
This change prevents the panic by converting such records to TXT (which is what they are in fact), but also auto-corrects any SPF or DKIM records to TXT ones so that next
pushwill see no modifications.