Include PTR types in SPF Builder#378
Merged
captncraig merged 5 commits intoStackExchange:masterfrom Aug 2, 2018
kjacobsen:patch-2
Merged
Include PTR types in SPF Builder#378captncraig merged 5 commits intoStackExchange:masterfrom kjacobsen:patch-2
captncraig merged 5 commits intoStackExchange:masterfrom
kjacobsen:patch-2
Conversation
Contributor
Author
|
Hi, Don't want to rush anyone, but can we look at getting this merged? |
Contributor
|
Sure. Thanks for the pr. |
rblenkinsopp
pushed a commit
to rblenkinsopp/dnscontrol
that referenced
this pull request
Aug 21, 2020
* Include PTR types in SPF * Simplify PTR and Exists logic * Include PTR test case * Include PTR test case * Remove extra }
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SPF builder doesn't support PTR types.
I think PTR counts as a DNS lookup, but happy for more opinions on the matter.