CLOUDFLAREAPI: Reduce confusion by making CF_CNAME_FLATTEN_ON and CF_PROXY_ON mutually exclusive #4026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudflare API silently ignores/discards the CNAME flattening setting when proxy is enabled, which leads to confusing behavior and drift.
Even worse, the CNAME flattening setting isn't set, so dnscontrol continuously sees drift and tries to re-apply the setting.
Per DNSControl Opinion 6 ("if it is ambiguous in DNS, it is forbidden in DNSControl"), we now reject configurations that set both modifiers on the same record.
Collaborator
|
Smart! Yes, I agree that making them mutually exclusive is for the best. (and you get extra credit for citing the Opinion list :-) ) |
tlimoncelli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloudflare API silently ignores/discards the CNAME flattening setting when proxy is enabled, which leads to confusing behavior and drift.
Even worse, the CNAME flattening setting isn't set, so dnscontrol continuously sees drift and tries to re-apply the setting.
Per DNSControl Opinion 6 ("if it is ambiguous in DNS, it is forbidden in DNSControl"), we now reject configurations that set both modifiers on the same record.