Potential fix for code scanning alert no. 44: Incomplete regular expression for hostnames#4111
Merged
tlimoncelli merged 1 commit intomainfrom Mar 2, 2026
Merged
Potential fix for code scanning alert no. 44: Incomplete regular expression for hostnames#4111tlimoncelli merged 1 commit intomainfrom
tlimoncelli merged 1 commit intomainfrom
Conversation
…ession for hostnames Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/StackExchange/dnscontrol/security/code-scanning/44
To fix the problem, all literal dots in the hostname portion of the regex must be escaped so they are treated as literal periods instead of “any character”. Since the base URL is held in
selfLinkBasePathand then concatenated into the regex, the best approach is to escape the dots inselfLinkBasePathat construction time (while keeping/and:unescaped), so that the resulting full regex behaves as intended and still clearly expresses the expected URL prefix.Concretely, in
providers/gcloud/gcloudProvider.go, keepselfLinkBasePathas a normal string constant for use elsewhere, but when buildingnetworkURLCheck, wrapselfLinkBasePathwithregexp.QuoteMeta. Then append the rest of the regex (project ID and network name parts) as before.regexp.QuoteMeta(selfLinkBasePath)will escape all regex metacharacters (including.), eliminating the over-permissive matching on the host, while preserving the intended matching of path structure and constraints on project/network names. No new imports are needed, sinceregexpis already imported. The only line to change is the definition ofnetworkURLCheck.Suggested fixes powered by Copilot Autofix. Review carefully before merging.