CICD: Restrict permissions in .github/workflows/pr_build.yml#4121
Merged
tlimoncelli merged 2 commits intomainfrom Mar 2, 2026
Merged
CICD: Restrict permissions in .github/workflows/pr_build.yml#4121tlimoncelli merged 2 commits intomainfrom
tlimoncelli merged 2 commits intomainfrom
Conversation
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/StackExchange/dnscontrol/security/code-scanning/36
In general, the fix is to explicitly define
permissionsfor theGITHUB_TOKENin the workflow, restricting it to the least privileges needed. Since this workflow only checks out code, uses caches, runs tests, uploads artifacts, and runs GoReleaser builds without creating releases or pushing tags, it should only require read access to repository contents.The best way to fix this without changing existing functionality is to add a
permissionsblock near the top of the workflow (at the root level, alongsidename,on, andenv). This will apply to all jobs that do not overridepermissions. We should setcontents: read, which matches the minimal recommendation in the CodeQL message and is sufficient foractions/checkoutand other used actions. No additional scopes (likepull-requests: writeorpackages: write) appear necessary based on the provided snippet.Concretely, in
.github/workflows/pr_build.yml, after theon:block (lines 6–15) and before theenv:block (line 18), insert:No imports or additional definitions are needed; this is purely a YAML configuration change.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.