CICD: Restrict permissions in .github/workflows/pr_lint.yml #4122
Merged
tlimoncelli merged 1 commit intomainfrom Mar 2, 2026
Merged
CICD: Restrict permissions in .github/workflows/pr_lint.yml #4122tlimoncelli merged 1 commit intomainfrom
tlimoncelli merged 1 commit intomainfrom
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/StackExchange/dnscontrol/security/code-scanning/37
To fix the problem, explicitly define a
permissionsblock that restricts theGITHUB_TOKENto the minimal required scope. For a lint-only workflow that just checks out code and runs Go linters,contents: readis typically sufficient. This can be set either at the root of the workflow (applies to all jobs) or at the job level. Since the workflow currently has a single job, either is acceptable; adding it at the workflow root is the clearest and matches the CodeQL recommendation.The best minimal fix without altering existing functionality is to add a root-level
permissionssection directly under thename:line, beforeon:, withcontents: read. This will ensure thegolangci-lintjob gets a read-only token for repository contents while keeping all existing behavior intact. No other files, imports, or definitions are needed, and no changes to steps or actions are required.Concretely, in
.github/workflows/pr_lint.yml, insert:after line 1 (
name: "PR: Lint"). All other lines remain unchanged.Suggested fixes powered by Copilot Autofix. Review carefully before merging.