CICD: Restrict permissions in .github/workflows/pr_integration_tests.yml#4124
Merged
tlimoncelli merged 1 commit intomainfrom Mar 2, 2026
Merged
CICD: Restrict permissions in .github/workflows/pr_integration_tests.yml#4124tlimoncelli merged 1 commit intomainfrom
tlimoncelli merged 1 commit intomainfrom
Conversation
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
tlimoncelli
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/StackExchange/dnscontrol/security/code-scanning/35
In general, the fix is to add an explicit
permissionsblock that grants only the minimal scopes required for the workflow. For this workflow, the jobs need to (a) check out code, which requirescontents: read, and (b) interact with the actions runtime (artifacts, cache) which uses the internalactionspermission that is enabled by default and does not need to be specified. They do not appear to modify repository contents, issues, or pull requests. The best non-breaking change is to add a workflow-levelpermissionsblock after theon:section, settingcontents: read. This will apply to both jobs since neither currently defines its ownpermissionsblock. No other functionality needs to change.Concretely, in
.github/workflows/pr_integration_tests.yml, insert:between the
on:block (ending at line 15) and theenv:block (starting at line 18). This explicitly restricts theGITHUB_TOKENpermissions for all jobs in this workflow while keeping all current behavior intact. No imports or additional methods are needed because this is a pure YAML configuration change within the workflow file.Suggested fixes powered by Copilot Autofix. Review carefully before merging.