fix(ENG-12465): use absolute URLs for README images to fix npm display#28
Merged
fix(ENG-12465): use absolute URLs for README images to fix npm display#28
Conversation
Relative paths (assets/banner-*.svg, assets/demo-*.svg) resolve correctly on GitHub but break on npm's markdown renderer which has no base URL context. Replaced with raw.githubusercontent.com URLs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
hiskudin
changed the title
There was a problem hiding this comment.
Pull request overview
Updates README image references so they render correctly on npm, which doesn’t resolve relative asset paths in rendered markdown/HTML.
Changes:
- Replace relative
assets/*.svgpaths with absoluteraw.githubusercontent.comURLs for the banner images. - Replace relative
assets/*.svgpaths with absoluteraw.githubusercontent.comURLs for the “How It Works” diagram.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assets/banner-*.svg,assets/demo-*.svg) with absoluteraw.githubusercontent.comURLsTest plan
🤖 Generated with Claude Code