Skip to content

feat(ENG-10566): add show branding flag#24

Merged
jpmiguel merged 3 commits intomainfrom
eng-10566/show-branding
Jul 15, 2025
Merged

feat(ENG-10566): add show branding flag#24
jpmiguel merged 3 commits intomainfrom
eng-10566/show-branding

Conversation

@jpmiguel
Copy link
Copy Markdown
Contributor

(optional) Context

Checklist

Use the checklist below as a guide to ensure your PR is ready for review

  • 📝 PR has description (comment /describe to generate a description via the PR agent)
  • 🧪 PR includes tests
  • 🪵 PR includes logs
  • 📸 PR includes screenshots demonstrating the impact (eg: UI screenshots, stack diffs, perf improvements etc.)
  • 📜 Docs have been updated where relevant (eg: README.md, docs.stackone.com, hub.stackone.com etc.)

@jpmiguel jpmiguel requested a review from a team as a code owner July 14, 2025 16:13
@jpmiguel jpmiguel requested review from jerann and jrebocho July 14, 2025 16:14
@jpmiguel jpmiguel requested a review from a team July 15, 2025 13:47
README.md Outdated
| **containerId** | string | No | ID of the container element where the file picker will be mounted. |
| **baseUrl** | string | No | Which API instance should it connect to. |
| **fields** | string[] | No | Which fields from the raw picked file will be mapped on the files picked callback. |
| **showBranding** | string | No | Show StackOne footer on the file picker, it is defaulted to true. |
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this a boolean though?

@jpmiguel jpmiguel merged commit 5726416 into main Jul 15, 2025
2 checks passed
@jpmiguel jpmiguel deleted the eng-10566/show-branding branch July 15, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants