Skip to content

fix(ENG-10975): pre-fill existing values#23

Merged
adefreitas merged 2 commits intoStackOneHQ:mainfrom
adefreitas:ENG-10975/fix-edit-account-in-new-hub
Nov 5, 2025
Merged

fix(ENG-10975): pre-fill existing values#23
adefreitas merged 2 commits intoStackOneHQ:mainfrom
adefreitas:ENG-10975/fix-edit-account-in-new-hub

Conversation

@adefreitas
Copy link
Copy Markdown
Collaborator

@adefreitas adefreitas commented Nov 5, 2025

Summary by cubic

Fixes edit mode in the new hub so existing integration values are pre-filled instead of opening the “link account” flow. Addresses ENG-10975.

  • Bug Fixes

    • Pre-fill the form by resetting and emitting default values on mount (reset + onChange).
    • Correctly evaluate field values using setupValue when available, so existing values show up in edit mode.
    • Hide password toggle in IntegrationFields to prevent exposing sensitive values.
  • Dependencies

    • Bump @stackone/malachite from 0.5.2 to 0.22.0.

Written for commit c6cf655. Summary will update automatically on new commits.

Copilot AI review requested due to automatic review settings November 5, 2025 17:15
@adefreitas adefreitas changed the title [ENG-10975] fix: pre-fill existing values fix(ENG-10975): pre-fill existing values Nov 5, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors conditional evaluation logic to check setupValue before attempting evaluation, updates the @stackone/malachite dependency from version 0.5.2 to 0.22.0, and adds a password toggle control and form change notification.

Key changes:

  • Refactored logic in useIntegrationPicker to move valueToEvaluate calculation before the null check, ensuring that setupValue is considered in the conditional evaluation
  • Updated @stackone/malachite dependency to version 0.22.0
  • Added showPasswordToggle={false} prop to the password input field and triggered onChange when default values are reset

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/modules/integration-picker/hooks/useIntegrationPicker.ts Refactored to calculate valueToEvaluate before null check in two locations, ensuring setupValue is properly evaluated
src/modules/integration-picker/components/IntegrationFields.tsx Added onChange call on form reset and disabled password toggle for Input component
package.json Updated @stackone/malachite dependency from 0.5.2 to 0.22.0
package-lock.json Updated lockfile to reflect new @stackone/malachite version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/modules/integration-picker/components/IntegrationFields.tsx Outdated
@adefreitas adefreitas requested a review from a team November 5, 2025 17:20
@adefreitas adefreitas merged commit 95d6233 into StackOneHQ:main Nov 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants