fix(ENG-10975): pre-fill existing values#23
Merged
adefreitas merged 2 commits intoStackOneHQ:mainfrom Nov 5, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors conditional evaluation logic to check setupValue before attempting evaluation, updates the @stackone/malachite dependency from version 0.5.2 to 0.22.0, and adds a password toggle control and form change notification.
Key changes:
- Refactored logic in
useIntegrationPickerto movevalueToEvaluatecalculation before the null check, ensuring thatsetupValueis considered in the conditional evaluation - Updated
@stackone/malachitedependency to version 0.22.0 - Added
showPasswordToggle={false}prop to the password input field and triggeredonChangewhen default values are reset
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/modules/integration-picker/hooks/useIntegrationPicker.ts | Refactored to calculate valueToEvaluate before null check in two locations, ensuring setupValue is properly evaluated |
| src/modules/integration-picker/components/IntegrationFields.tsx | Added onChange call on form reset and disabled password toggle for Input component |
| package.json | Updated @stackone/malachite dependency from 0.5.2 to 0.22.0 |
| package-lock.json | Updated lockfile to reflect new @stackone/malachite version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jpmiguel
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixes edit mode in the new hub so existing integration values are pre-filled instead of opening the “link account” flow. Addresses ENG-10975.
Bug Fixes
Dependencies
Written for commit c6cf655. Summary will update automatically on new commits.