fix: migrate to stackvox 0.4.x unified CLI#16
Merged
Conversation
… on fresh installs stackvox 0.3.x consolidated its CLI — there is no separate `stackvox-say` console_script anymore; speech goes through `stackvox say <text>` as a subcommand. notify.sh and Speaker.swift both still pointed at the old binary, so on fresh installs (where only `stackvox` exists in the venv) the existence guard bailed silently and voice never fired. install looks healthy, daemon is running, models are downloaded, the manual `stackvox speak` works — but hooks never speak. Reported in #14 by @OMauriStkOne. notify.sh - STACKVOX_SAY removed; speak_notification now invokes "$STACKVOX" say - voice_phrase_for gates on STACKVOX existence (was STACKVOX_SAY) - nudge_debug() helper writes to stderr only when STACKNUDGE_DEBUG=true. Logs the missing-binary and missing-daemon-socket cases that were previously hidden by the silent bail. The "voice silently no-ops" failure mode is now diagnosable by setting STACKNUDGE_DEBUG=true. Speaker.swift - Same migration on the Swift side (used by the menu bar's voice toggle preview and the voice-cycle preview in Settings) - Removed the now-redundant separate stackvox / stackvoxSay paths Verified locally with stackvox 0.3.x in the venv: `stackvox say --voice af_aoede ...` runs cleanly; notify.sh's voice path completes without error when STACKNUDGE_VOICE=true. Closes #14 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
9e6cebc to
68efe9c
Compare
Collaborator
Author
|
Confirmed against stackvox 0.4.0 on PyPI — |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stackvox 0.4.x consolidated its CLI — there is no separate `stackvox-say` console_script anymore; speech goes through `stackvox say ` as a subcommand. `notify.sh` and `Speaker.swift` both still pointed at the old binary, so on fresh installs (where only `stackvox` exists in the venv) the existence guard bailed silently and voice never fired.
Closes #14, reported by @OMauriStkOne.
Failure mode this fixes
Changes
`notify.sh`
`panel/Speaker.swift`
Test plan
Out of scope (deliberate)
🤖 Generated with Claude Code