Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves security by pinning GitHub Actions to a specific commit SHA instead of using mutable version tags. This follows security best practices by preventing potential supply chain attacks where tags could be moved to point to malicious code.
- Replaced version tag
@v15with commit SHA@3fdab59e74dda7831d7401f7aa1bb55d706913d7across workflow files - Added inline comments
# v15to maintain version traceability - Applied changes consistently to all reusable workflow references
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/sdk_publish.yaml |
Pinned the sdk-publish.yaml workflow to commit SHA with v15 comment |
.github/workflows/sdk_generation.yaml |
Pinned the workflow-executor.yaml workflow to commit SHA with v15 comment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic analysis
No issues found across 2 files
Linked issue analysis
Linked issue: ENG-11298: Github actions should be version pinned and policy set organization-wide
| Status | Acceptance criteria | Notes |
|---|---|---|
| ✅ | GitHub actions should be version pinned (no floating tags) — pin sdk_generation and sdk_publish workflows to commit SHAs | Replaced @V15 with commit SHA in both workflow files |
| ❌ | Policy set organization-wide to enforce action version pinning | No org policy or config changes present in the diffs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Pinned the sdk_generation and sdk_publish workflows to commit 3fdab59e for speakeasy-api/sdk-generation-action, replacing the floating v15 tag. Meets ENG-11298 by enforcing action version pinning for stability and security.
Written for commit 8a52647. Summary will update automatically on new commits.