Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances security by pinning GitHub Actions to specific commit SHAs instead of mutable version tags, following GitHub's recommended security best practices for workflow actions. This prevents potential supply chain attacks where malicious code could be introduced through tag updates.
- All three workflow files now reference commit SHA
3fdab59e74dda7831d7401f7aa1bb55d706913d7instead of version tagv15 - Version comments (
# v15) are retained for human readability and maintenance - Changes are applied consistently across all workflows using the
speakeasy-api/sdk-generation-action
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/tagging.yaml |
Pins the tag workflow action to commit SHA with version comment |
.github/workflows/sdk_publish.yaml |
Pins the SDK publish workflow action to commit SHA with version comment |
.github/workflows/sdk_generation.yaml |
Pins the workflow executor action to commit SHA with version comment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Pins our GitHub reusable workflows to a specific commit (3fdab59… for v15) to enforce version locking and comply with the org-wide policy in ENG-11298. Updated sdk_generation.yaml, sdk_publish.yaml, and tagging.yaml to use the pinned SHA.
Written for commit 47aaee7. Summary will update automatically on new commits.