Multiaccount SQS sensor capability #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefangusa
force-pushed
the
multiaccount_sensor
branch
from
bb752e3 to
4db6b59
Compare
stefangusa
force-pushed
the
multiaccount_sensor
branch
from
4db6b59 to
e06a9b2
Compare
blag
suggested changes
Dec 19, 2019
Contributor
blag
left a comment
blag
left a comment
There was a problem hiding this comment.
Looking mostly good, but needs some improvements.
stefangusa
force-pushed
the
multiaccount_sensor
branch
from
9ce1319 to
314351d
Compare
blag
reviewed
Dec 19, 2019
blag
approved these changes
Dec 19, 2019
Contributor
blag
left a comment
blag
left a comment
There was a problem hiding this comment.
One last tweak to exception message, but I think this is looking good.
Contributor
Author
|
And renamed 'roles_arns' to 'roles'. |
blag
approved these changes
Dec 20, 2019
Contributor
blag
left a comment
blag
left a comment
There was a problem hiding this comment.
Thanks for seeing this through!
stefangusa
force-pushed
the
multiaccount_sensor
branch
from
68d386e to
ae4a6f0
Compare
added 2 commits
April 9, 2020 20:09
nmaludy
suggested changes
Apr 9, 2020
Contributor
nmaludy
left a comment
nmaludy
left a comment
There was a problem hiding this comment.
Sorry two small changes.
Can you please add a CHANGELOG entry in: https://github.com/StackStorm-Exchange/stackstorm-aws/blob/master/CHANGES.md
And also bump the version in pack.yaml (https://github.com/StackStorm-Exchange/stackstorm-aws/blob/master/pack.yaml#L22) by 0.1 to be 1.3.0.
Please and thank you!
After these two things i'll gladly merge!
nmaludy
reviewed
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83