Skip to content

Conversation

@taijiji
Copy link
Contributor

@taijiji taijiji commented Sep 15, 2021

Fix #69
Tested in my vagrant environment.

Before

vagrant@st2vagrant:~$ sudo st2 trigger list --pack=napalm
+---------------------------+--------+---------------------------+
| ref                       | pack   | description               |
+---------------------------+--------+---------------------------+
| napalm.LLDPNeighborDecrea | napalm | Trigger which occurs when |
| se                        |        | a device's LLDP neighbors |
|                           |        | decrease                  |
+---------------------------+--------+---------------------------+

After

vagrant@st2vagrant:~$ sudo st2 trigger list --pack=napalm
+---------------------------+--------+---------------------------+
| ref                       | pack   | description               |
+---------------------------+--------+---------------------------+
| napalm.LLDPNeighborDecrea | napalm | Trigger which occurs when |
| se                        |        | a device's LLDP neighbors |
|                           |        | decrease                  |
| napalm.LLDPNeighborIncrea | napalm | Trigger which occurs when |
| se                        |        | a device's LLDP neighbors |
|                           |        | increase                  |
+---------------------------+--------+---------------------------+

@taijiji taijiji requested review from a team and floatingstatic as code owners September 15, 2021 07:38
@taijiji taijiji requested review from cognifloyd and removed request for a team September 15, 2021 07:38
@taijiji taijiji changed the title Fix #69 wrong "LLDPNeighborIncrease" sensor name Fix #69 wrong "LLDPNeighborIncrease" trigger name Sep 15, 2021
Copy link
Collaborator

@floatingstatic floatingstatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @taijiji . Looks good to me. I suspect this trigger name went undetected as the example rule that references the LLDP sensor trigger only references LLDPNeighborDecrease (probably enough for the original demo) .. see here. The sensor itself would actually emit an LLDPNeighborIncrease trigger on LLDP neighbor increase and your change will ensure that trigger is registered with stackstorm.

Thank you for contributing!

@floatingstatic floatingstatic merged commit 64fedfb into StackStorm-Exchange:master Sep 15, 2021
@floatingstatic floatingstatic self-assigned this Sep 15, 2021
@taijiji
Copy link
Contributor Author

taijiji commented Sep 16, 2021

@floatingstatic Excellent! Thank you for reviewing and merging it!

@taijiji taijiji deleted the patch-1 branch September 16, 2021 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LLDPNeighborDecrease trigger name are duplicated on lldp_sensor.yaml

2 participants