Add exceptions on action.py #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nzlosh
approved these changes
Aug 29, 2023
Member
|
@nzlosh I see you reviewed & approved the PR. Good to merge? |
Contributor
|
Yes, this PR looks good to me. The fallback from json to plain-text will give a bit more flexibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a Stackstorm workflow, the action netbox.delete.virtualization.virtual_machines works on NetBox but fails on Stackstorm.
When NetBox deletes an object, it replies a 204 error no content, r.json() fails.
The objective is that when NetBox replies a 500 error, the workflow works and it replies a string error in raw.