upgrade to latest networkx to allow running on py 3.9#237
Merged
m4dcoder merged 3 commits intoStackStorm:masterfrom Jun 3, 2021
Merged
upgrade to latest networkx to allow running on py 3.9#237m4dcoder merged 3 commits intoStackStorm:masterfrom
m4dcoder merged 3 commits intoStackStorm:masterfrom
Conversation
Minor update to networkx in requirements.txt to allow for updates of minor and patch releases to the networkx module.
m4dcoder
approved these changes
Jun 3, 2021
Collaborator
m4dcoder
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Just a minor note here. StackStorm, where orquesta is used, currently supports python 3.6 and 3.8. The change here described in the title for python 3.9 didn't affect the unit tests for python 3.6 and 3.8. It's also a good idea to keep networkx up to date.
Contributor
Author
|
Sorry, I should have mentioned that I'm using orquesta outside of stackstorm. I haven't tested this change with stackstorm. If there are functions in stackstorm that are receiving a [EDIT] |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Orquesta won't run on python 3.9+ because it currently has a dependency on
networkxversion 1.11. It doesn't look like the 1.x version ofnetworkxhas received any updates in quite a while. In Python 3.9, thegcdfunction used bynetworkxwas moved fromfunctionstomathpackage in the standard lib as described here. This PR updates orquesta to use the latest version ofnetworkxwhich is currently 2.5.1.The code has been modified where necessary and all tests are passing on my machine with Python 3.9.5. Let me know if there is anything else necessary. Thanks.