Remove duplicate test fixture files#6261
Merged
cognifloyd merged 1 commit intomasterfrom Oct 18, 2024
Merged
Conversation
These are not test files: - st2actions/tests/unit/test_async_runner.py - st2actions/tests/unit/test_polling_async_runner.py It looks like they were copied to st2tests/st2tests/mocks/runners/ at some point. Nothing imports from or uses the copies in st2actions, so just delete them.
pull-request-size
Bot
added
the
size/L
amanda11
approved these changes
Oct 18, 2024
nzlosh
approved these changes
Oct 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are not test files, they are fixtures:
st2actions/tests/unit/test_async_runner.pyst2actions/tests/unit/test_polling_async_runner.pyIt looks like they were copied to
st2tests/st2tests/mocks/runners/at some point. Nothing imports from or uses the copies in st2actions, so this PR just deletes them.Here is the copy of these files: