Skip to content

Reformat and improve Bashisms in upgrade script#423

Merged
blag merged 4 commits intomasterfrom
improve-upgrade-script
Mar 6, 2020
Merged

Reformat and improve Bashisms in upgrade script#423
blag merged 4 commits intomasterfrom
improve-upgrade-script

Conversation

@blag
Copy link
Copy Markdown
Contributor

@blag blag commented Mar 5, 2020

Make this script more bulletproof, and some indentation fixups as well.

I might rebase this into two commits - fixing Bashisms and fixing up indentation.

Copy link
Copy Markdown
Contributor

@m4dcoder m4dcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@punkrokk
Copy link
Copy Markdown
Member

punkrokk commented Mar 6, 2020

Thank you. I’ve been trying to clean up a lot of those in the bootstrap scripts

@blag blag force-pushed the improve-upgrade-script branch from 4ea5565 to 6c1f61d Compare March 6, 2020 08:45
@blag blag merged commit e0935f2 into master Mar 6, 2020
@blag blag deleted the improve-upgrade-script branch March 6, 2020 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants