Skip to content

Conversation

@pradnya-orchestral
Copy link
Contributor

Added HTML code for pop-up box which will open once click on Clone button. On pop-up box for destination pack name there is dropdown, where I am showing list of all destination packs except source pack name. By default first name from list will be shown selected in dropdown. Once user select destination pack name and enter destination action name, on submit button I am calling clone API.

@m4dcoder m4dcoder added this to the 3.7.0 milestone Oct 8, 2021
Copy link
Contributor

@m4dcoder m4dcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The destination pack drop down box doesn't work right. If I applied an actions filter, select an action, and then click clone, there's no list in the drop down box I can select from.

@m4dcoder
Copy link
Contributor

m4dcoder commented Oct 8, 2021

@pradnya-orchestral Also, if a destination action already exists and I did not click overwrite, the clone action fails but then doesn't tell me what the problem is. Instead there's just a quick popup on the bottom that says to go to the developers' console. Can we post the error in the popup instead of asking me to go to the developer console?

@m4dcoder
Copy link
Contributor

@pradnya-orchestral This is still not working right.

  1. Let's say I have pack named test1 with only 1 action named weather. When I try to clone examples.weather with overwrite to pack test1, I get the both Action weather has been cloned successfully and Unable to clone action. There's no error in the log.
  2. If I try to clone examples.weather to test1 pack again, the test1 pack is no longer in the drop down box. I have to logout and close the browser, login again, and redo the clone to see test1 pack under the drop down list.
  3. Once I cloned the examples.weather, even though I can see test1.weather created in the command line, I have to manually refresh the UI to have test1.weather listed.

Copy link
Contributor

@m4dcoder m4dcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pradnya-orchestral There is a regression on the action/workflow delete button. I cannot check the remove files checkbox. If I test this on master, this issue doesn't exist. Please fix.

@m4dcoder m4dcoder merged commit 74092f7 into StackStorm:master Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants