Merged
Conversation
cognifloyd
approved these changes
Sep 26, 2022
arm4b
reviewed
Sep 26, 2022
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
|
|
||
| v2.4.3 |
Member
There was a problem hiding this comment.
The Changelog is a good addition, but the reality st2web version was last updated 3 years ago: 656c1e4
In other words, as a user, there is no easy way to find out which change shipped with which stackstorm version.
Thinking how to point or hint to the respective StackStorm version? As that's what really matters.
and we really package the st2web repository in line with the stackstorm versioning.
What if we ignore the package.json version in the Changelog, but include the real stackstorm version?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.