-
-
Notifications
You must be signed in to change notification settings - Fork 82
Search Criteria Support in the Web UI - Updated #992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
merge master
|
I used the triggers as placeholder suggestions for the search pattern item names but can change it to either no suggestion or item.data, item.time... |
arm4b
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @cded, really great work with refactoring it. Some advanced rules from the https://docs.stackstorm.com/rules.html?highlight=search#advanced-comparison and #964 (review) worked nicely 👍
Just a few minor comments before merging:
1) Placeholder Suggestions
I used the triggers as placeholder suggestions for the search pattern item names but can change it to either no suggestion or item.data, item.time...
Yes, thanks for thinking about it 👍
Indeed, we don't need a placeholder suggestion in these scenarios as we don't know the nested schema for these objects so worth removing suggestions for the "Item Name *":

2) Please add a Changelog record for this PR.
https://github.com/StackStorm/st2web/blob/master/CHANGELOG.rst#added
3) Bonus task with the delete button
However, with the multiple item patterns added, the delete button for search criteria might be confused with the item criteria:

If we can move the delete button somewhere to a better place that would be nice. Perhaps closer to the "Key" placeholder? Any other ideas?
If it's too involved and outside of the PR scope, - that's fine, we can skip it.
arm4b
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Eugen C. <1533818+armab@users.noreply.github.com>


Resolves: #492
Closes #964
Adds support for Search Criteria and nested parameter fields for rules.
Updates for the previous PR: #964
stackstormSearchCrit.mp4
Open to suggestions for the UI design