Skip to content

Conversation

@cded
Copy link
Contributor

@cded cded commented Oct 11, 2022

Resolves: #492
Closes #964

Adds support for Search Criteria and nested parameter fields for rules.

Updates for the previous PR: #964

stackstormSearchCrit.mp4

Open to suggestions for the UI design

@cded cded changed the title WIP: Search Criteria Support in the Web UI - Updated Search Criteria Support in the Web UI - Updated Oct 12, 2022
@cded
Copy link
Contributor Author

cded commented Oct 12, 2022

I used the triggers as placeholder suggestions for the search pattern item names but can change it to either no suggestion or item.data, item.time...

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cded, really great work with refactoring it. Some advanced rules from the https://docs.stackstorm.com/rules.html?highlight=search#advanced-comparison and #964 (review) worked nicely 👍

Just a few minor comments before merging:

1) Placeholder Suggestions

I used the triggers as placeholder suggestions for the search pattern item names but can change it to either no suggestion or item.data, item.time...

Yes, thanks for thinking about it 👍

Indeed, we don't need a placeholder suggestion in these scenarios as we don't know the nested schema for these objects so worth removing suggestions for the "Item Name *":
image

2) Please add a Changelog record for this PR.

https://github.com/StackStorm/st2web/blob/master/CHANGELOG.rst#added

3) Bonus task with the delete button

This looks ok:
image

However, with the multiple item patterns added, the delete button for search criteria might be confused with the item criteria:
image

If we can move the delete button somewhere to a better place that would be nice. Perhaps closer to the "Key" placeholder? Any other ideas?
If it's too involved and outside of the PR scope, - that's fine, we can skip it.

@arm4b arm4b added this to the 3.8.0 milestone Oct 13, 2022
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

That looks really nice 💯 , thanks a lot!

@arm4b arm4b added the feature label Oct 13, 2022
Co-authored-by: Eugen C. <1533818+armab@users.noreply.github.com>
@arm4b arm4b merged commit 0011c47 into StackStorm:master Oct 13, 2022
@arm4b arm4b deleted the search-criteria branch November 13, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants