Move st2web.annotations into st2web.service #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arm4b
approved these changes
Apr 17, 2019
Member
|
@warrenvw Is there anything that blocks merging this and release a new patched chart version? |
arm4b
reviewed
Apr 26, 2019
| appVersion: 3.0dev | ||
| name: stackstorm-ha | ||
| version: 0.11.0 | ||
| version: 0.12.0 |
Member
There was a problem hiding this comment.
Just not important note for future: ideal here would be to bump patch version aka 0.11.1 since it's a small fix, no new functionality introduced.
Contributor
Author
There was a problem hiding this comment.
Considered this, but incorrectly assumed change was user visible. It is not. So 0.11.1 was the better choice. Next time I will look at the change more closely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
st2web.annotationstost2web.service.annotations, to matchvalues.yaml.