Skip to content

Move st2web.annotations into st2web.service #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 25, 2019
Merged

Move st2web.annotations into st2web.service #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02cf554
Move st2web.annotations into st2web.service
warrenvw Apr 16, 2019
c792a45
Merge branch 'master' into st2web-annotations
warrenvw Apr 16, 2019
eaf7a65
Bump version and add a changelog
warrenvw Apr 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## In Development

## v0.12.0
* Move `st2web.annotations` to `st2web.service.annotations` to match `values.yaml` (#66)

## v0.11.0
* Add st2chatops support (@mosn, @rapittdev) (#55)

Expand Down
2 changes: 1 addition & 1 deletion Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v1
# Update StackStorm version here to rely on other Docker images tags
appVersion: 3.0dev
name: stackstorm-ha
version: 0.11.0
version: 0.12.0
Copy link
Member

@arm4b arm4b Apr 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just not important note for future: ideal here would be to bump patch version aka 0.11.1 since it's a small fix, no new functionality introduced.

Copy link
Contributor Author

@warrenvw warrenvw Apr 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considered this, but incorrectly assumed change was user visible. It is not. So 0.11.1 was the better choice. Next time I will look at the change more closely.

description: StackStorm K8s Helm Chart, optimized for running StackStorm in HA environment.
home: https://stackstorm.com/#product
icon: https://avatars1.githubusercontent.com/u/4969009
Expand Down
4 changes: 2 additions & 2 deletions templates/services.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ metadata:
{{- if .Values.st2web.service.hostname }}
external-dns.alpha.kubernetes.io/hostname: {{ .Values.st2web.service.hostname | quote }}
{{- end }}
{{- if .Values.st2web.annotations }}
{{ toYaml .Values.st2web.annotations | indent 4 }}
{{- if .Values.st2web.service.annotations }}
{{ toYaml .Values.st2web.service.annotations | indent 4 }}
{{- end }}
labels:
app: st2web
Expand Down