Use st2 3.1dev #67
Merged
Use st2 3.1dev #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arm4b
reviewed
May 11, 2019
| ## In Development | ||
|
|
||
| ## v0.13.1 | ||
| * Pin st2 version to `v3.1dev` as a new latest development version (#67) |
Member
There was a problem hiding this comment.
I think 0.14.0 would be more appropriate versioning since it's not a bugfix or patch but a version change.
https://github.com/StackStorm/stackstorm-ha/blob/master/CHANGELOG.md#v083 and https://github.com/StackStorm/stackstorm-ha/blob/master/CHANGELOG.md#v083 were a bit messy due to updated release plans changes and version renames.
Contributor
Author
There was a problem hiding this comment.
I was going to do a minor version bump for the reasons you mention, but I noticed that v0.8.4 just bumped patch when changing appVersion from v2.10dev to 3.0dev. Figured it set a precedent...
Anyhow, I agree that we shouldn't bump patch when appVersion is changed. I'll make the change you suggest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since st2
3.0.0has been released, bump appVersion to3.1dev.