Skip to content

STAC-0: rename stackpack delete version flag to stackpack-version #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deontaljaard merged 1 commit into from
Apr 22, 2026
Merged

STAC-0: rename stackpack delete version flag to stackpack-version #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/stackpack/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const (
IdFlag = "id"
NameFlag = "name"
UnlockedStrategyFlag = "unlocked-strategy"
VersionFlag = "version"
StackpackVersionFlag = "stackpack-version"
AllFlag = "all"
DevOnlyFlag = "dev-only"
)
6 changes: 3 additions & 3 deletions cmd/stackpack/stackpack_delete_version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ func StackpackDeleteVersionCommand(cli *di.Deps) *cobra.Command {
Short: "Delete a specific version of a StackPack",
Long: "Delete a specific version of a StackPack from the server. The version cannot be deleted if it is currently in use by an installed instance.",
Example: `# delete version 1.0.0 of the kubernetes StackPack
sts stackpack delete-version --name kubernetes --version 1.0.0`,
sts stackpack delete-version --name kubernetes --stackpack-version 1.0.0`,
RunE: cli.CmdRunEWithApi(RunStackpackDeleteVersionCommand(args)),
}
common.AddRequiredNameFlagVar(cmd, &args.Name, "Name of the StackPack")
cmd.Flags().StringVar(&args.Version, VersionFlag, "", "Version to delete")
cmd.MarkFlagRequired(VersionFlag) //nolint:errcheck
cmd.Flags().StringVar(&args.Version, StackpackVersionFlag, "", "Version to delete")
cmd.MarkFlagRequired(StackpackVersionFlag) //nolint:errcheck
return cmd
}

Expand Down
4 changes: 2 additions & 2 deletions cmd/stackpack/stackpack_delete_version_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ func setupStackPackDeleteVersionCmd(t *testing.T) (*di.MockDeps, *cobra.Command)

func TestStackpackDeleteVersionPrintToConsole(t *testing.T) {
cli, cmd := setupStackPackDeleteVersionCmd(t)
di.ExecuteCommandWithContextUnsafe(&cli.Deps, cmd, "delete-version", "--name", "kubernetes", "--version", "1.0.0")
di.ExecuteCommandWithContextUnsafe(&cli.Deps, cmd, "delete-version", "--name", "kubernetes", "--stackpack-version", "1.0.0")

expectedSuccessMessage := []string{"Successfully deleted version 1.0.0 of StackPack kubernetes"}
assert.True(t, cli.MockPrinter.HasNonJsonCalls)
Expand All @@ -30,7 +30,7 @@ func TestStackpackDeleteVersionPrintToConsole(t *testing.T) {

func TestStackpackDeleteVersionPrintToJson(t *testing.T) {
cli, cmd := setupStackPackDeleteVersionCmd(t)
di.ExecuteCommandWithContextUnsafe(&cli.Deps, cmd, "delete-version", "--name", "kubernetes", "--version", "1.0.0", "-o", "json")
di.ExecuteCommandWithContextUnsafe(&cli.Deps, cmd, "delete-version", "--name", "kubernetes", "--stackpack-version", "1.0.0", "-o", "json")

expectedJsonCalls := []map[string]interface{}{{
"deleted": "1.0.0",
Expand Down
Loading