Really support SLES 12 and SLES 15. #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
qingling128
reviewed
Nov 1, 2019
igorpeshansky
commented
Nov 1, 2019
Contributor
Author
igorpeshansky
left a comment
igorpeshansky
left a comment
There was a problem hiding this comment.
Thanks for the review. PTAL.
igorpeshansky
commented
Nov 1, 2019
Contributor
Author
igorpeshansky
left a comment
igorpeshansky
left a comment
There was a problem hiding this comment.
This breaks on some older platforms (wheezy, CentOS 6). I'll fix this and ask for another review once done.
Contributor
|
Sounds good. Let me know when it's ready for another look. |
igorpeshansky
commented
Nov 1, 2019
Contributor
Author
igorpeshansky
left a comment
igorpeshansky
left a comment
There was a problem hiding this comment.
Ok, this should be good to review now.
igorpeshansky
force-pushed
the
igorpeshansky-sles-build
branch
2 times, most recently
from
b196940 to
d479209
Compare
igorpeshansky
commented
Nov 5, 2019
Contributor
Author
igorpeshansky
left a comment
igorpeshansky
left a comment
There was a problem hiding this comment.
Some fixes to the Provides/Requires dependencies. Should be good now.
igorpeshansky
added a commit
that referenced
this pull request
Dec 9, 2019
Fixes the breakage introduced by #71, and includes the following changes: - Add ENABLE_COREFILES to the RPM script - Use pidfile to properly manage (start/stop) the daemon in the RPM script - Remove the now-redundant lockfile code - Allow using /etc/default/stackdriver-agent in the RPM script - Implement try_restart in the DEB script - Change the RPM script to use force-reload instead of reload - Remove unused legacy genhostid command - Remove broken and unused collectdmon support from the DEB script - Remove unused "wait-for-stop" functionality from the DEB script - Remove unused "disable via defaults" functionality from the DEB script
igorpeshansky
added a commit
that referenced
this pull request
Jan 2, 2020
Fixes the breakage introduced by #71, and includes the following changes: - Add ENABLE_COREFILES to the RPM script - Use pidfile to properly manage (start/stop) the daemon in the RPM script - Remove the now-redundant lockfile code - Allow using /etc/default/stackdriver-agent in the RPM script - Implement try_restart in the DEB script - Change the RPM script to use force-reload instead of reload - Remove unused legacy genhostid command - Remove broken and unused collectdmon support from the DEB script - Remove unused "wait-for-stop" functionality from the DEB script - Remove unused "disable via defaults" functionality from the DEB script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make the RPM build honor the
OUTPUT_DIRsetting, and make the DEB builds a bit more uniform with the RPM ones.This is a rebase of the
sles-buildbranch on top of the lateststackdriver-agent-5.5.2(with version support), but with additional fixes that allow building all of the RPM packages from it. It encapsulates the SLES-specific bits into the main configs.I will be doing some additional testing of this tomorrow, but this is ready for an initial review.