Skip to content

Fix builds with versions of automake prior to 1.13.#179

Merged
igorpeshansky merged 1 commit intostackdriver-agent-5.8.1from
igorpeshansky-fix-older-automake
Feb 26, 2020
Merged

Fix builds with versions of automake prior to 1.13.#179
igorpeshansky merged 1 commit intostackdriver-agent-5.8.1from
igorpeshansky-fix-older-automake

Conversation

@igorpeshansky
Copy link
Copy Markdown

@igorpeshansky igorpeshansky commented Feb 26, 2020

This fixes the following build error on older platforms:

./configure: line 37411: syntax error near unexpected token `$am__api_version,lt,1.12,'
./configure: line 37411: `AX_COMPARE_VERSION($am__api_version,lt,1.12,'

A bit of context for the change: older versions of automake did not automatically parse the AC_CONFIG_MACRO_DIR directive, so we have to explicitly tell aclocal to find extra macros there. Also, running libtoolize before aclocal ensures that the libtool macros have been copied into m4 for aclocal to find (otherwise it would sporadically use the libtool macros that came with whatever version of automake was installed, rather than those supplied by libtool itself).

@igorpeshansky igorpeshansky requested a review from a team February 26, 2020 19:07
@ghost ghost requested review from bmoyles0117 and removed request for a team February 26, 2020 19:07
Copy link
Copy Markdown

@bmoyles0117 bmoyles0117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igorpeshansky igorpeshansky merged commit 6fd9250 into stackdriver-agent-5.8.1 Feb 26, 2020
@igorpeshansky igorpeshansky deleted the igorpeshansky-fix-older-automake branch February 26, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants