Skip to content

Revert "Revert "Set GO111MODULE for go and promu commands, so that they work" #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2019
Merged

Revert "Revert "Set GO111MODULE for go and promu commands, so that they work" #171

merged 1 commit into from
Sep 9, 2019

Conversation

@qingling128
Copy link
Contributor

@qingling128 qingling128 commented Sep 9, 2019

Reverts #166

jkohen
jkohen approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@jkohen jkohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, it's finally working :)

@qingling128 qingling128 merged commit 03da9af into master Sep 9, 2019
@qingling128 qingling128 deleted the revert-166-gomod branch September 9, 2019 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jkohen jkohen jkohen approved these changes

@davidbtucker davidbtucker davidbtucker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@qingling128 @jkohen @davidbtucker @googlebot