fix: handle non-semver ToolHive versions and use configurable timeout

[therealnb]

This PR fixes two issues in the ToolHive client:

1. Non-semver version handling: Updates _parse_toolhive_version to gracefully handle development builds that don't follow semver (e.g., 'build-7c3a3077') by returning a default version '0.0.0-dev' instead of raising an error. This allows connections to succeed with development builds while still logging the issue.

2. Configurable timeout: Replaces the hardcoded 1.0s timeout with self.timeout in _is_toolhive_available for better configurability.

Changes

• Modified src/mcp_optimizer/toolhive/toolhive_client.py

Testing

• Tested with development build versions
• Verified timeout configuration is respected

Note

That code was inserted as part of #19 so we should consider if the patch above is consistent with that.

[claude]

PR Review for #52

Summary

Good fixes that improve robustness. The changes handle non-semver versions gracefully and use the correct timeout configuration. Both changes are sensible improvements.

Code Quality & Best Practices ✅

• Clean implementation following existing patterns
• Proper error handling with logging
• Good use of default fallback for non-semver versions

Issues & Suggestions 🔍

Critical:

• Missing test coverage: The new behavior in _parse_toolhive_version (lines 159-167) isn't tested. Add a test case for non-semver versions like "build-7c3a3077" to ensure it returns Version.parse("0.0.0-dev") and logs appropriately.

Minor:

• Line 166: Missing comma after default_version="0.0.0-dev" - this works in Python but inconsistent with multi-line function call style elsewhere in the codebase
• Consider: Should we distinguish between different non-semver patterns? Current implementation treats all invalid versions the same way. This is probably fine for now but worth documenting if certain patterns need special handling in the future.

Performance & Security ✅

• No performance concerns
• No security issues
• Using configurable timeout (line 177) is more flexible than hardcoded value

Regressions & Breaking Changes ✅

• No breaking changes
• Backward compatible: previously would raise error, now gracefully handles edge case
• Existing tests should pass (though new test needed for new behavior)

Recommendations

1. Add test case to test_toolhive_client.py for non-semver version parsing
2. Fix formatting: add trailing comma on line 166

Estimated fix time: 5 minutes

[ptelang]

Good find! Changes look good!