Skip to content

Conversation

@aponcedeleonch
Copy link
Member

No description provided.

@claude
Copy link

claude bot commented Dec 3, 2025

PR Review

Summary

This PR configures Renovate to automatically update pyproject.toml dependencies. Changes look good overall with minor considerations.

✅ Positives

  • Enables lock file maintenance for automated dependency updates
  • Uses pep621 manager (correct for pyproject.toml)
  • rangeStrategy: bump aligns with modern dependency management

🔍 Considerations

1. Range Strategy Impact

  • bump updates version ranges (e.g., ^1.0.0 → ^2.0.0), which may introduce breaking changes
  • Consider: pin for more control or add automerge rules for patch/minor updates only
  • Current setup means manual review of all PRs (which is safer)

2. Lock File Maintenance

  • This will create periodic PRs to update lock files even without version range changes
  • Recommended: Add schedule to avoid noise (e.g., weekly/monthly)

3. Missing Configurations (Optional)

  • No schedule defined - defaults to anytime
  • No automerge rules - all PRs require manual approval
  • No separation rules for major vs minor/patch updates

Suggested Enhancement (optional)

"packageRules": [
  {
    "matchManagers": ["pep621"],
    "matchUpdateTypes": ["patch", "minor"],
    "rangeStrategy": "bump",
    "automerge": true
  },
  {
    "matchManagers": ["pep621"],
    "matchUpdateTypes": ["major"],
    "rangeStrategy": "bump"
  }
]

Verdict

LGTM - Configuration is valid and conservative. Current setup is safe (manual review for all updates).

@aponcedeleonch aponcedeleonch merged commit 6c41309 into main Dec 3, 2025
6 checks passed
@aponcedeleonch aponcedeleonch deleted the renovate-pep-bump branch December 3, 2025 15:59
therealnb added a commit that referenced this pull request Dec 4, 2025
…mples (#98)

* thv group investigation

Signed-off-by: nigel brown <nigel@stacklok.com>

* Example tweaks

Signed-off-by: nigel brown <nigel@stacklok.com>

* Skip registry if in k8s mode

Signed-off-by: nigel brown <nigel@stacklok.com>

* URL normalization for streamable-http transport
For streamable-http:
  Strips URL fragments (#github → removed)
  Converts /sse paths to /mcp
  Ensures path ends with /mcp if missing
For SSE:
  preserves original URL (fragments needed for container identification)

Signed-off-by: nigel brown <nigel@stacklok.com>

* Update ToolHive API models (#92)

Automated update of ToolHive API models from OpenAPI specification.

Co-authored-by: aponcedeleonch <7890853+aponcedeleonch@users.noreply.github.com>

* chore(deps): update actions/checkout action to v6 (#77)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update peter-evans/create-pull-request action to v7.0.9 (#81)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update docker/metadata-action action to v5.10.0 (#87)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update renovate.json to bump pyproject.toml dependencies (#93)

* Fix formatting issues

* Fix URL normalization to avoid double-adding /mcp

- Updated normalization logic to check if /mcp already exists in path before adding it
- Updated test expectations to account for URL normalization behavior
- Fixes failing tests where URLs like /mcp/test-server were getting /mcp appended

---------

Signed-off-by: nigel brown <nigel@stacklok.com>
Co-authored-by: stackloke2e <160783949+stackloke2e@users.noreply.github.com>
Co-authored-by: aponcedeleonch <7890853+aponcedeleonch@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Alejandro Ponce de Leon <aponcedeleonch@stacklok.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants