fix(api): expose Flusher through logging middleware so SSE /events st…#4
Merged
Merged
Conversation
…reams The logging middleware wraps http.ResponseWriter in a struct that did not implement http.Flusher, so the type assertion in the /api/v1/events handler always failed with 500 "streaming not supported". The same pattern silently prevented per-chunk flushing in the exec-stream NDJSON and worker RPC paths (chunks were coalesced until handler return). Adds Flush() (forwards to the embedded writer) and Unwrap() (so http.ResponseController can traverse the wrapper). Includes a regression test that verifies both the type assertion and http.ResponseController.Flush work through the wrapped writer. Also clarifies the /files/move row in the README so the body schema (old_path / new_path) is visible without chasing the rest-api.md link. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…reams
The logging middleware wraps http.ResponseWriter in a struct that did not implement http.Flusher, so the type assertion in the /api/v1/events handler always failed with 500 "streaming not supported". The same pattern silently prevented per-chunk flushing in the exec-stream NDJSON and worker RPC paths (chunks were coalesced until handler return).
Adds Flush() (forwards to the embedded writer) and Unwrap() (so http.ResponseController can traverse the wrapper). Includes a regression test that verifies both the type assertion and http.ResponseController.Flush work through the wrapped writer.
Also clarifies the /files/move row in the README so the body schema (old_path / new_path) is visible without chasing the rest-api.md link.