chore: remove stale/dangerous deploy-all.js + fix stale prod URLs#146
Merged
Conversation
Deploys are automatic on merge to main (Railway + Vercel GitHub integrations), so the manual one-command path is obsolete — and dangerous. - Delete server/scripts/deploy-all.js: it re-ran stale one-off Symbiosis/ Plata-Mia prod data mutations (whose db:* npm scripts no longer exist), did supabase db push, and auto-committed/pushed main. - Remove the deploy:all script from server/package.json. - Rewrite the PRODUCTION_DEPLOYMENT.md top section to document the auto-deploy-on-merge flow + the manual Supabase data step. - Fix stale defaults: verify scripts' FRONTEND_URL and client/.env.example's prod API host now point at stadium.joinwebzero.com / stadium-production-996a. - CLAUDE.md: drop deploy:all from the operational list; note auto-deploy.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deploys are already automatic (merge to
main→ Railway + Vercel via GitHub integrations), so the manualdeploy-all.jspath is obsolete — and unsafe. This removes it and fixes lingering stale references.Changes
server/scripts/deploy-all.js— it re-ran stale one-off Symbiosis/Plata-Mia production data mutations (whosedb:*npm scripts no longer exist, so it was already broken), ransupabase db push, and auto-committed/pushedmain. Dangerous to run by accident.deploy:allfromserver/package.json.PRODUCTION_DEPLOYMENT.mdtop section to document the real flow: auto-deploy on merge tomain, plus the manual Supabase data step (migrations/backfills aren't automatic). CLI deploy kept as a documented fallback.verify-production.js+verify-main-deployed.jsFRONTEND_URLdefault →https://stadium.joinwebzero.com(was an oldclient-n7lu4qlus-…vercel.app).client/.env.exampleprod API comment →stadium-production-996a.up.railway.app/api(was the stalehw4os4c00wg4k80o…host).deploy:allfrom the operational list; note auto-deploy.What's kept
verify:production+verify:main-deployed— read-only health checks (URLs corrected).railway up/vercel --prodCLI steps in the doc as a fallback.Test plan
package.jsonstill valid JSON.npm test(server) — 257 passed.npm run build+npm run lint(client) — green.deploy-all(operational) orhw4os4c00wg4k80o/client-n7lu4qlusin scripts/config.No runtime code touched — scripts/docs/config only. Per CLAUDE.md §6: draft, never merging.