fix(security): rate-limit the public non-member apply route#159
Merged
Conversation
The unauthenticated POST /:slug/applications/non-member route emails the team on every call and was only under the generous global 200/min limiter, so a single IP could flood the inbox. Add a tight per-IP limiter (5 per 15 min) on this route only. It can't relay to arbitrary addresses (fixed recipients), so this just stops inbox flooding.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a tight per-IP rate limit to the public, unauthenticated
POST /:slug/applications/non-memberroute, which emails the team (info@ccsacha@) on every call.Before, it was only covered by the global limiter (200/min), so one IP could flood the team inbox. Now: 5 requests per 15 min per IP on this route only.
Why this is the only app-level spam surface worth tightening
Change
server/api/routes/program.routes.js: newnonMemberApplyLimiter(express-rate-limit, already a dep) applied to the non-member route. Generous for a real applicant (incl. retries), tight enough to kill a flood.Test plan
npm test— 36 files, 291 pass (no regressions).Related hardening (not in this PR — yours)