Merged
Conversation
staust
requested review from
0x46616c6b,
kaitimmer and
monotek
and removed request for
a team
ricoberger
approved these changes
Jan 19, 2022
Member
ricoberger
left a comment
ricoberger
left a comment
There was a problem hiding this comment.
Please use v3 tag after this is merged.
ricoberger
reviewed
Jan 19, 2022
monotek
approved these changes
Jan 19, 2022
timkante
approved these changes
Jan 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my proposal of using official actions for docker login, build and push.
This allows us to speed up or ci pipelines due to caching of the images. For us this change gain up to 50% speed on the deployment step.
It is arguable to split this whole action up into its parts to be able to just use everything from the original source and be able to use every feature from those. This would be a change I don't want to do as should be something discussed and decided in diablo, I guess.
As input parameters are changing I would release a v3. There I might need help to write a proper migration guide which is shown via dependabot.
Example:
before: https://github.com/Staffbase/pickle-rick/runs/4817457094?check_suite_focus=true
after: https://github.com/Staffbase/pickle-rick/runs/4865195476?check_suite_focus=true