Skip to content

Switch to Staffbase Artifactory as new default docker registry#59

Merged
kaitimmer merged 2 commits intomainfrom
change_default_registry
Jan 26, 2023
Merged

Switch to Staffbase Artifactory as new default docker registry#59
kaitimmer merged 2 commits intomainfrom
change_default_registry

Conversation

@kaitimmer
Copy link
Copy Markdown
Contributor

@kaitimmer kaitimmer commented Jan 24, 2023

Type of Change

  • Enhancement / new feature

Description

This switches the default registry from registry.staffbase.com to staffbase.jfrog.io which is our new prefered way of releasing images.

The idea would be to release a new version of this action and have repositories switch gradually.

When updating there is also the need to switch the following:

  • docker-image -> replace /private with /sb-images
  • docker-username -> replace DOCKER_USERNAME with ARTIFACTORY_USERNAME
  • docker-password -> replace DOCKER_PASSWORDwith ARTIFACTORY_PASSWORD
  • docker-registry -> if set replace registry.staffbase.com with staffbase.jfrog.io

The new secrets are available as a company-wide Github secret or environment variable.

Clusters are already prepared for the change and should be able to pull images from the new registry.

Checklist

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Review the Contributing Guideline and sign CLA
  • Reference relevant issue(s) and close them after merging

@kaitimmer kaitimmer requested a review from a team as a code owner January 24, 2023 16:31
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 24, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@kaitimmer
Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@kaitimmer
Copy link
Copy Markdown
Contributor Author

recheck

github-actions Bot added a commit that referenced this pull request Jan 24, 2023
Comment thread README.md
Comment thread README.md
Comment thread action.yml
Comment thread README.md
Comment thread README.md
@kaitimmer
Copy link
Copy Markdown
Contributor Author

In a few talks we decided to keep the defaults Staffbase specific. Just removing the registry URL default didn't feel right, as we also set other Staffbase specific defaults like the GitHub User, the gitops repository name, ….

@kaitimmer kaitimmer merged commit afea3ad into main Jan 26, 2023
@kaitimmer kaitimmer deleted the change_default_registry branch January 26, 2023 12:09
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants