Skip to content

NFS-234: adds branchId and branchSlug to token#11

Merged
Ninerian merged 2 commits intomasterfrom
NFS-234-update-claims
Jan 7, 2020
Merged

NFS-234: adds branchId and branchSlug to token#11
Ninerian merged 2 commits intomasterfrom
NFS-234-update-claims

Conversation

@Ninerian
Copy link
Copy Markdown
Contributor

@Ninerian Ninerian commented Jan 3, 2020

What have I done?

  • added missing claims branch_id and branch_slug
  • adds getter methods for both claims

What should you do?

  • code review

@Ninerian Ninerian requested review from netzmensch and staust January 3, 2020 09:23
@Ninerian Ninerian self-assigned this Jan 3, 2020
Copy link
Copy Markdown
Contributor

@staust staust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please convert tabs into spaces (or atleast fix the indention)

@Ninerian
Copy link
Copy Markdown
Contributor Author

Ninerian commented Jan 3, 2020

please convert tabs into spaces (or atleast fix the indention)

Fixed

@Ninerian Ninerian force-pushed the NFS-234-update-claims branch from ef46635 to 8052f9b Compare January 3, 2020 13:32
@Ninerian Ninerian requested a review from staust January 4, 2020 16:40
@Ninerian Ninerian merged commit c6a5adc into master Jan 7, 2020
@Ninerian Ninerian deleted the NFS-234-update-claims branch January 7, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants