NFS-1239: Link updated#19
Merged
cornelius-behrend merged 4 commits intomasterfrom Jan 14, 2021
Merged
Conversation
Ninerian
requested changes
Jan 14, 2021
Contributor
Ninerian
left a comment
Ninerian
left a comment
There was a problem hiding this comment.
Looks good to me. Please also raise the version number in the composer.json to the next patch version so you don't have to create another PR for that 😄
Ninerian
approved these changes
Jan 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What have I done?
The link in the readme was altered to the working one.
Also, I updated the tests to run through. This might be moved to a separate pull request.
What should you do?
Please check if link is correct as mentioned in Pull Request.